This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Manager is not element #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
clero
force-pushed
the
manager_is_not_element
branch
from
ce012c8 to
cc344d6
Compare
init function is defined in Element god class but is used only for plugins initialization after structure and settings loading. This patch delegate Subsystem initialization to SystemClass which is the direct parent. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Merged
Contributor
Author
clero
force-pushed
the
manager_is_not_element
branch
from
cc344d6 to
fd2ebe3
Compare
Contributor
|
the decrease in coverage is only related to dead getKind() methods that can't be removed yet. |
parameter/ParameterType.cpp
Outdated
Contributor
There was a problem hiding this comment.
coding style: missing whitespace after "+"
Contributor
clero
force-pushed
the
manager_is_not_element
branch
from
fd2ebe3 to
c080eb4
Compare
The element class really looks like a god class with stuff that has really nothing to do with its role. toString and appendTitle are good example of stuff that should be move away from it. This patch move those two functions into utility where they seems to belong. Signed-off-by: Sébastien Gonzalve <oznog@users.noreply.github.com> Signed-off-by: Jules Clero <julesx.clero@intel.com>
SelectionCriteria class is dependant from Element class because of the checksum calculation algorithm which is based on child name. In preparation of a rework, we exclude it from the structure checksum calculation. Moreover the criterion mechanism is not a part of the parameter-framework structure. Thus, this decision is fair. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Contributor
Author
|
closed for master submission |
Contributor
Author
|
@dawagner in fact maybe it can be good to send it on next branch as it already has been updated to the new log API |
Contributor
Author
|
getKind must be removed from ParameterMgr! |
clero
force-pushed
the
manager_is_not_element
branch
from
c080eb4 to
44713bb
Compare
ParameterManager does not have to be a part of the Element tree. Indeed, it is not represented in any xml file. This patch avoids this inheritance and removes some "tricks" which was used to forget the ParameterMgr root element. Signed-off-by: Jules Clero <julesx.clero@intel.com>
dawagner
added a commit
that referenced
this pull request
Apr 30, 2015
Manager is not element Avoid ParameterMgr inheritance to Element Allows to avoid tree structure guess work
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid ParameterMgr inheritance to Element
Allows to avoid tree structure guess work